fix: improve fields type for generic components
#14974
Open
+54
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #14893
This PR reintroduces the original solution I had proposed in #14893. A suggestion was made in that PR to simplify the type, but that appears to have been a mistake as it caused issues with generic components.
Included in this PR is a test that would otherwise fail - a function that represents a generic form component
After the update to the
fieldstype in #14893, a type error occurs in generic<Form>components on theform.fieldsproxy. The.allIssues()method does not exist on the type and attempting to.set(data)yields a type error thatdatais not compatible despite being the same type as the form's input type.Current workaround is to assign
fieldsto a variable and assert it asRemoteFormFields<unknown>. But that reveals a separate issue, which I've proposed a fix for in #14973.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits