Skip to content

fix(url): handle arbitrary number of levels for relative paths #10603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+28 −9
Closed

fix(url): handle arbitrary number of levels for relative paths #10603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd469a
fix(url): handle arbitrary number of levels for relative paths
Oct 10, 2025
c3bb466
added fix for paths starting with single period
Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions src/core/utils/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,31 @@ export function sanitizeUrl(url) {
if (urlTrimmed.startsWith("/")) {
return `${urlObject.pathname}${urlObject.search}${urlObject.hash}`
}

if (urlTrimmed.startsWith("./")) {
return `.${urlObject.pathname}${urlObject.search}${urlObject.hash}`
}

if (urlTrimmed.startsWith("../")) {
return `..${urlObject.pathname}${urlObject.search}${urlObject.hash}`

// Handle relative paths (./path, ../path, ./../../path, etc.)
if (urlTrimmed.startsWith("./") || urlTrimmed.startsWith("../")) {
Copy link
Contributor

@glowcloud glowcloud Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (urlTrimmed.startsWith("./") || urlTrimmed.startsWith("../")) {
if (urlTrimmed.startsWith("./") || urlTrimmed.startsWith("../")) {
const relativePath = urlTrimmed.match(/^(\.\.?\/)+/)[0]
const remainingPath = urlObject.pathname.substring(1)
return `${relativePath}${remainingPath}${urlObject.search}${urlObject.hash}`
}

Copy link
Author

@DavidVogel DavidVogel Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glowcloud Yes, that approach works for me.

const segments = urlTrimmed.split("/")
let relativePath = ""
let pathStartIndex = 0

// Process initial relative segments
for (let i = 0; i < segments.length; i++) {
if (segments[i] === ".") {
relativePath += "./"
pathStartIndex = i + 1
} else if (segments[i] === "..") {
relativePath += "../"
pathStartIndex = i + 1
} else {
break
}
}

// Get the remaining path from the URL object
const remainingPath = urlObject.pathname.substring(1)
return `${relativePath}${remainingPath}${urlObject.search}${urlObject.hash}`
}

return `${urlObject.pathname.substring(1)}${urlObject.search}${urlObject.hash}`
}

Expand All @@ -78,4 +94,3 @@ export function sanitizeUrl(url) {
return blankURL
}
}

4 changes: 4 additions & 0 deletions test/unit/core/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,6 +1486,10 @@ describe("utils", () => {
expect(sanitizeUrl("./openapi.json")).toEqual("./openapi.json")
expect(sanitizeUrl("..openapi.json")).toEqual("..openapi.json")
expect(sanitizeUrl("../openapi.json")).toEqual("../openapi.json")
expect(sanitizeUrl("../../openapi.json")).toEqual("../../openapi.json")
expect(sanitizeUrl("../../../openapi.json")).toEqual("../../../openapi.json")
expect(sanitizeUrl("../../../../openapi.json")).toEqual("../../../../openapi.json")
expect(sanitizeUrl("./../../../openapi.json")).toEqual("./../../../openapi.json")
})

it("should gracefully handle empty strings", () => {
Expand Down