Change how libraries are specified to the linker when using searched libs #890
+150
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
daveinglis
force-pushed
the
building_tests_fixes_windows
branch
7 times, most recently
from
19b9514 to
c224e9e
Compare
…libs - remove the platform specifics from computeLibraryArgs (we cannot assume that all libraries have a lib prefix and what there suffix is.) So we now use the FileType prefix and remove any suffix when using searchPathFlagsForLD (the linker wilk know...), moving this into the LinkerSpec.LibrarySpecifier extension, this allows for proper searching of libraries, and linking of dynamic libraries (especially on Windows).
daveinglis
force-pushed
the
building_tests_fixes_windows
branch
from
c224e9e to
843e629
Compare
daveinglis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that all libraries have a lib prefix and what the suffix is.) So we
now use the FileType prefix and remove any suffix when using
searchPathFlagsForLD (the linker will know...), moving this into the
LinkerSpec.LibrarySpecifier extension, this allows for proper searching
of libraries, and linking of dynamic libraries (especially on Windows).