Skip to content

Conversation

@vsapsai
Copy link
Contributor

@vsapsai vsapsai commented Nov 7, 2025

The idea is the same as Clang flag -fcrash-diagnostics-dir but for explicit module builds.

Making it a build setting instead of an environment variable on purpose. The plan is to have this setting more visible and not hidden.

rdar://164202916

The idea is the same as Clang flag `-fcrash-diagnostics-dir` but for
explicit module builds.

Making it a build setting instead of an environment variable on purpose.
The plan is to have this setting more visible and not hidden.

rdar://164202916
@vsapsai
Copy link
Contributor Author

vsapsai commented Nov 7, 2025

I'm not particularly happy that I have reproducerOutputPath both in ClangExplicitModulesPayload and in PrecompileClangModuleTaskKey but I haven't found a better approach. Any improvements in this area are welcome.

Another questionable moment is storing reproducerOutputPath in a payload at all. I have considered making it available through some delegate (most likely through TaskExecutionDelegate). But the reproducer location is relevant only for explicitly built modules, so I've decided to put this information into a more specific class which turned out to be a payload.

Copy link
Collaborator

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks ok to me

@vsapsai
Copy link
Contributor Author

vsapsai commented Nov 7, 2025

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants