WiX: remove support for packaging the legacy runtime #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the legacy SDK packaging and remove support for it. Collapse all the various sites into the new layout only. Furthermore, rename the targets to remove the `Experimental` in the identifiers.
This updates the android packaging to include the new experimental SDK as the default SDK. It additionally packages up the static runtime and brings the packaging layout in line with the Windows SDK packaging. It is able to sufficiently remove the dependency on the legacy SDK in the build to be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes support for the legacy RTL SDK from the Windows installer and build system, streamlining the build process and simplifying related code. It also introduces a new XSLT-based post-processing step to ensure compliance with ICE71 validation requirements for MSI packages. The changes affect build properties, installer logic, and package definitions, focusing on eliminating legacy paths and improving package validation.
Removal of legacy RTL SDK support:
rtllib.wixproj,rtllib.wxs,rtlmsi.wixproj,rtlmsi.wxs,rtlmsm.wixproj, andrtlmsm.wxs, from thertl/legacydirectory. [1] [2] [3] [4] [5] [6]IncludeLegacySDKand experimental SDKs fromDirectory.Build.props,installer.wixproj, andwindows.wixproj, eliminating conditional inclusion of legacy SDKs in builds and installers. [1] [2] [3] [4] [5] [6] [7]Installer and build property updates:
SideBySideUpgradeStrategy.propsto rename and consolidate upgrade code properties, removing references to experimental and legacy upgrade codes. [1] [2]installer.wxsby removing conditional package inclusion for the legacy SDK and eliminating experimental SDK install properties. [1] [2]Package validation and compliance:
SuppressIcesproperty inDirectory.Build.propsto avoid validation errors for missing DiskId 1 entries in the Media table.AddDiskIds.xsl, and a corresponding post-processing build target inwindows.wixprojto ensure DiskId is correctly set for components, addressing ICE71 compliance. [1] [2]