[Parser] Add 'atContextualKeywordPrefixedSyntax' method #3023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
approved these changes
Mar 19, 2025
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thank you. Much cleaner than the old rules
Sources/SwiftParser/Statements.swift
Outdated
| $0.consumeAnyToken() | ||
| return $0.atValidTrailingClosure(flavor: exprFlavor) | ||
| } | ||
| return isClosure && acceptClosure |
Member
There was a problem hiding this comment.
Can we avoid the isClosure check if acceptClosure is false?
Unified disambiguation method for contextual-keyword prefixed syntax.
rintaro
force-pushed
the
parser-contetual-keyword-prefixed
branch
2 times, most recently
from
725db10 to
3c00ba6
Compare
rintaro
force-pushed
the
parser-contetual-keyword-prefixed
branch
from
3c00ba6 to
5bf4217
Compare
Member
Author
|
@swift-ci Please test |
rintaro
force-pushed
the
parser-contetual-keyword-prefixed
branch
from
2f77f68 to
2a45ef7
Compare
Just like 'return', 'then' statement should accept operand on the next line.
rintaro
force-pushed
the
parser-contetual-keyword-prefixed
branch
from
2a45ef7 to
ebf79c3
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified disambiguation method for contextual-keyword prefixed syntax.