Update syntax for #objectFormat per SE-0492 #3170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
ahoppen
reviewed
Oct 17, 2025
| /// swift repo, and breaking clients with the new addition to the protocol. | ||
| extension BuildConfiguration { | ||
| /// FIXME: This should be @_spi(ExperimentalLanguageFeatures) but cannot due | ||
| /// to rdar://147943518, https://github.com/swiftlang/swift/issues/80313 |
Member
There was a problem hiding this comment.
I think this FIXME is no longer relevant now, right?
Also, could you mark this default implementation as deprecated so that clients conforming to BuildConfiguration without implementing isActiveTargetObjectFormat get a warning, similar to what we do in
…TargetObjectFormat
Contributor
Author
|
@swift-ci please test |
ahoppen
approved these changes
Oct 22, 2025
Contributor
Author
|
@swift-ci please test Windows platform |
DougGregor
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/swiftlang/swift-evolution/blob/main/proposals/0492-section-control.md, which is now accepted.