-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[SE-0494][StdLib] Add isTriviallyIdentical(to:) Methods to Array, ArraySlice, and ContiguousArray
#82438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[SE-0494][StdLib] Add isTriviallyIdentical(to:) Methods to Array, ArraySlice, and ContiguousArray
#82438
Changes from 4 commits
c1a4725
97af676
ec5b23e
6d13a8f
9d15f14
2236650
9fe77b4
f5d33b2
15a5e99
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //===--- ArraySliceTests.swift --------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import TestsUtils | ||
|
|
||
| public let benchmarks = [ | ||
| BenchmarkInfo(name: "ArraySliceEqualUnique", runFunction: run_ArraySliceEqualUnique, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ArraySliceEqualShared", runFunction: run_ArraySliceEqualShared, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ArraySliceIdentical", runFunction: run_ArraySliceIdentical, tags: [.validation, .api, .Array]), | ||
| ] | ||
|
|
||
| @inline(never) | ||
| public func run_ArraySliceEqualUnique(_ n: Int) { | ||
| let a1 = ArraySlice(0 ..< n) | ||
| let a2 = ArraySlice(0 ..< n) | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ArraySliceEqualShared(_ n: Int) { | ||
| let a1 = ArraySlice(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ArraySliceIdentical(_ n: Int) { | ||
| let a1 = ArraySlice(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1.isTriviallyIdentical(to: a2)) | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //===--- ArrayTests.swift -------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import TestsUtils | ||
|
|
||
| public let benchmarks = [ | ||
| BenchmarkInfo(name: "ArrayEqualUnique", runFunction: run_ArrayEqualUnique, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ArrayEqualShared", runFunction: run_ArrayEqualShared, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ArrayIdentical", runFunction: run_ArrayIdentical, tags: [.validation, .api, .Array]), | ||
| ] | ||
|
|
||
| @inline(never) | ||
| public func run_ArrayEqualUnique(_ n: Int) { | ||
| let a1 = Array(0 ..< n) | ||
| let a2 = Array(0 ..< n) | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ArrayEqualShared(_ n: Int) { | ||
| let a1 = Array(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ArrayIdentical(_ n: Int) { | ||
| let a1 = Array(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1.isTriviallyIdentical(to: a2)) | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //===--- ContiguousArrayTests.swift ---------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import TestsUtils | ||
|
|
||
| public let benchmarks = [ | ||
| BenchmarkInfo(name: "ContiguousArrayEqualUnique", runFunction: run_ContiguousArrayEqualUnique, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ContiguousArrayEqualShared", runFunction: run_ContiguousArrayEqualShared, tags: [.validation, .api, .Array]), | ||
| BenchmarkInfo(name: "ContiguousArrayIdentical", runFunction: run_ContiguousArrayIdentical, tags: [.validation, .api, .Array]), | ||
| ] | ||
|
|
||
| @inline(never) | ||
| public func run_ContiguousArrayEqualUnique(_ n: Int) { | ||
| let a1 = ContiguousArray(0 ..< n) | ||
| let a2 = ContiguousArray(0 ..< n) | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ContiguousArrayEqualShared(_ n: Int) { | ||
| let a1 = ContiguousArray(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1 == a2) | ||
| } | ||
| } | ||
|
|
||
| @inline(never) | ||
| public func run_ContiguousArrayIdentical(_ n: Int) { | ||
| let a1 = ContiguousArray(0 ..< n) | ||
| let a2 = a1 | ||
| for _ in 0 ..< 100_000 { | ||
| check(a1.isTriviallyIdentical(to: a2)) | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -511,3 +511,20 @@ extension _SliceBuffer { | |
| return ContiguousArray(_buffer: result) | ||
| } | ||
| } | ||
|
|
||
| extension _SliceBuffer { | ||
| @_alwaysEmitIntoClient | ||
| internal func isTriviallyIdentical(to other: Self) -> Bool { | ||
| guard | ||
| // FIXME: use builtin == function | ||
| // self.owner == other.owner, | ||
| unsafe unsafeBitCast(self.owner, to: Int.self) == unsafeBitCast(other.owner, to: Int.self), | ||
|
||
| unsafe (self.subscriptBaseAddress == other.subscriptBaseAddress), | ||
| self.startIndex == other.startIndex, | ||
| self.endIndexAndFlags == other.endIndexAndFlags | ||
| else { | ||
| return false | ||
| } | ||
| return true | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // RUN: %target-run-simple-swift(-parse-as-library) | ||
| // REQUIRES: executable_test | ||
| // END. | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import StdlibUnittest | ||
|
|
||
| @main | ||
| enum ArraySliceTests { | ||
| static func main() { | ||
| let testSuite = TestSuite("ArraySliceTests") | ||
| testSuite.test("Identical", testIdentical) | ||
| runAllTests() | ||
| } | ||
|
|
||
| static func testIdentical() { | ||
| let a1: ArraySlice = [0, 1, 2, 3] | ||
| expectTrue(a1.isTriviallyIdentical(to: a1)) | ||
|
|
||
| let a2: ArraySlice = a1 | ||
| expectTrue(a1.isTriviallyIdentical(to: a2)) | ||
|
|
||
| var a3: ArraySlice = a2 | ||
| a3.reserveCapacity(0) | ||
| expectFalse(a1.isTriviallyIdentical(to: a3)) | ||
|
|
||
| let a4: ArraySlice = [0, 1, 2, 3] | ||
| expectFalse(a1.isTriviallyIdentical(to: a4)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lorentey Did we want to ship these opaque?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would prevent generic specialization, so the answer is no, sadly.