Skip to content

Add SIL verification for borrow and mutate accessors and some other minor fixes #85362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add SIL verification for borrow and mutate accessors and some other minor fixes #85362

wants to merge 8 commits into from
+327 −65

Conversation

@meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Nov 6, 2025 •
edited
Loading

  • Add SIL verification to ensure we don't return local addresses from borrow and mutate accessors: Address results can only be projections of self or borrow/mutate accessor results.
  • Add memory lifetime verification for borrow and mutate accessors: This ensures the address result of the borrow/mutate accessors is not used after self is destroyed.
  • Fix memory lifetime verification for store_borrow projections
  • Update return_borrow handling
  • Update move-only checker for mutate results

@meg-gupta meg-gupta force-pushed the moreborrow branch 2 times, most recently from bb1cbe6 to 8a512d9 Compare November 6, 2025 12:45
@meg-gupta
Copy link
Contributor Author

meg-gupta commented Nov 6, 2025

@swift-ci test

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Nov 6, 2025

@swift-ci test

@meg-gupta meg-gupta marked this pull request as ready for review November 6, 2025 18:57
@meg-gupta meg-gupta requested a review from atrick November 6, 2025 18:57
@meg-gupta
Copy link
Contributor Author

meg-gupta commented Nov 6, 2025

@swift-ci test

@meg-gupta
Copy link
Contributor Author

meg-gupta commented Nov 7, 2025

@swift-ci test windows platform

1 similar comment
@meg-gupta
Copy link
Contributor Author

meg-gupta commented Nov 8, 2025

@swift-ci test windows platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@kavon kavon Awaiting requested review from kavon kavon is a code owner

@atrick atrick Awaiting requested review from atrick

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@meg-gupta