[CAS] Support legacy prefix map option #85375
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
jamieQ
reviewed
Nov 7, 2025
lib/Frontend/CompilerInvocation.cpp
Outdated
| if (auto Mapping = llvm::MappedPrefix::getFromJoined(Opt)) { | ||
| Opts.ScannerPrefixMapper.push_back({Mapping->Old, Mapping->New}); | ||
| } else { | ||
| Diags.diagnose(SourceLoc(), diag::error_prefix_mapping, Opt); |
Contributor
There was a problem hiding this comment.
FYI i just deleted this diagnostic id in #85282 since it seemed to be unused, so that might cause some build failures
Contributor
Author
There was a problem hiding this comment.
I see. I forgot to pull and I was wondering why the old diag was there when I bring back the logic.
Bring back legacy prefix map option to allow an older swift-driver to work with newer swift-frontend. For old swift-driver, it will always send the old style prefix map option, so the new compiler needs to support that. rdar://164208526
cachemeifyoucan
force-pushed
the
eng/PR-164208526
branch
from
3d85f82 to
23b42cf
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please clean smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back legacy prefix map option to allow an older swift-driver to work with newer swift-frontend. For old swift-driver, it will always send the old style prefix map option, so the new compiler needs to support that.
rdar://164208526