Run tests in SwiftPtyProcess #1933
Draft
+4
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously to work around the end of large output streams being dropped in tests we spawned a read-only child process instead of a PTY. After some testing I'm not longer seeing this issue, so remove this workaround. This makes running and debugging tests the same, and colorizes swift-testing output the same as it was in debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To work around the end of large output streams being dropped in tests we spawned a read-only child process instead of a PTY. After some testing I'm not longer seeing this issue, so remove this workaround.
This makes running and debugging tests the same, and colorizes swift-testing output the same as it was in debugging.
Tasks
Required tests have been writtenDocumentation has been updated