Skip to content
This repository was archived by the owner on Apr 20, 2025. It is now read-only.

Run flake8 as a test #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Run flake8 as a test #142

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c6ca7
Run flake8 as a test
and-semakin Nov 7, 2019
01e0896
Convert Path object to str for Python 3.5
and-semakin Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_flake8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
class Flake8RunnerTest(unittest.TestCase):
def test_run_flake8(self):
proj_root = pathlib.Path(__file__).parent.parent
paths = [proj_root / dirname for dirname in test_modules]
paths = [str(proj_root / dirname) for dirname in test_modules]
Copy link
Owner

@sybrenstuvel sybrenstuvel Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that Python 3.5 is EOL, is this still necessary?

Copy link
Contributor Author

@and-semakin and-semakin Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify, what exactly do you mean? Conversion to a str?

Copy link
Owner

@sybrenstuvel sybrenstuvel Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.


style_guide = flake8.get_style_guide()
report = style_guide.check_files(paths)
Expand Down