Adding fresh table loading on scan start #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psergee
reviewed
Dec 3, 2025
| pub(crate) fn table_to_use(&self) -> error::Result<table::Table> { | ||
| match self.catalog { | ||
| Some(ref catalog) => { | ||
| futures::executor::block_on(catalog.load_table(self.table.identifier())) |
There was a problem hiding this comment.
Loading a table from local disk or shared drive, or S3 may take some time. Using block_on would block our runtime thread for that duration. Can we instead use async to avoid blocking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Helps to close [censored].
What changes are included in this PR?
A function which returns fresh table version from catalog if it is provided within
IcebergTableProvider. Otherwise the inner table clone is being returned.This function is used inside
TableProvider::scanimplementation forIcebergTableProvider.Are these changes tested?
They are tested manually and (partially) via integration tests in the main application.