Skip to content

fix: remove await from OTEL handleSignal interceptor #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 10, 2025
Merged

fix: remove await from OTEL handleSignal interceptor #1803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
03bace3
add test displaying NDE from 1.11.3 replay
chris-olszewski Oct 17, 2025
f0efdfd
add test for 1.13.1 replay
chris-olszewski Oct 17, 2025
954d706
update core-sdk
chris-olszewski Oct 20, 2025
ef42599
break up
chris-olszewski Oct 20, 2025
b205aa9
fix: no longer yield during OTEL handleSignal
chris-olszewski Oct 20, 2025
3fd63f3
chore: move conditional logic to SDK flag
chris-olszewski Oct 21, 2025
9de4ee8
chore: move flag checking logic to interceptor
chris-olszewski Oct 21, 2025
cb95455
history creation code
chris-olszewski Oct 21, 2025
6f53259
run formatter
chris-olszewski Oct 21, 2025
b1c3a47
chore: refactor semver checking to be more robust
chris-olszewski Oct 22, 2025
f7d8598
fix(otel): remove yield from execute interceptor
chris-olszewski Oct 22, 2025
ec8319e
chore: add replay test for otel smorgasbord
chris-olszewski Oct 22, 2025
b8dadee
chore(otel): add failing test for signaling workflow
chris-olszewski Oct 22, 2025
a1952bc
clean up tests and flags
chris-olszewski Oct 23, 2025
56ab659
run formatter
chris-olszewski Oct 23, 2025
a2f4822
refactor sdk access with runtime workflow access
chris-olszewski Oct 31, 2025
678c55d
add new workflow service rpc calls
chris-olszewski Oct 23, 2025
3308dc5
silence require warnings
chris-olszewski Oct 31, 2025
5d0c85a
remove error in semver parse
chris-olszewski Oct 31, 2025
7451855
remove await in incoming activity
chris-olszewski Oct 31, 2025
b581e8d
pr feedback
chris-olszewski Nov 3, 2025
f165855
wip
mjameswh Nov 7, 2025
c09b986
wip
mjameswh Nov 7, 2025
f7d19c7
pr feedback: change flag definitions to better match existing flags
chris-olszewski Nov 7, 2025
b683184
Merge branch 'main' into olszewski/fix_otel_interceptor_nde
mjameswh Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 95 additions & 57 deletions packages/core-bridge/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions packages/core-bridge/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,28 +25,28 @@ async-trait = "0.1.83"
bridge-macros = { path = "bridge-macros" }
futures = { version = "0.3", features = ["executor"] }
neon = { version = "1.0.0", default-features = false, features = [
"napi-6",
"futures",
"napi-6",
"futures",
] }
opentelemetry = "0.29"
opentelemetry = "0.31"
os_pipe = "1.2.1"
parking_lot = "0.12"
prost = "0.13"
prost-types = "0.13"
prost = "0.14"
prost-types = "0.14"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
temporal-sdk-core = { version = "*", path = "./sdk-core/core", features = [
"ephemeral-server",
"ephemeral-server",
] }
temporal-client = { version = "*", path = "./sdk-core/client" }
thiserror = "2"
tokio = "1.13"
tokio-stream = "0.1"
tonic = "0.13"
tonic = "0.14"
tracing = "0.1"
tracing-subscriber = { version = "0.3", default-features = false, features = [
"parking_lot",
"env-filter",
"registry",
"ansi",
"parking_lot",
"env-filter",
"registry",
"ansi",
] }
2 changes: 1 addition & 1 deletion packages/core-bridge/sdk-core
Open in desktop
Submodule sdk-core updated 41 files
+4 −4 .github/workflows/per-pr.yml
+6 −5 Cargo.toml
+4 −0 README.md
+26 −4 client/src/metrics.rs
+176 −6 client/src/raw.rs
+19 −3 client/src/worker_registry/mod.rs
+13 −0 core-api/src/telemetry.rs
+2 −1 core-api/src/telemetry/metrics.rs
+2 −1 core-c-bridge/Cargo.toml
+112 −22 core-c-bridge/include/temporal-sdk-core-c-bridge.h
+6 −0 core-c-bridge/src/client.rs
+223 −57 core-c-bridge/src/worker.rs
+3 −3 core/Cargo.toml
+2 −2 core/src/core_tests/updates.rs
+9 −0 core/src/internal_flags.rs
+4 −11 core/src/protosext/protocol_messages.rs
+1 −0 core/src/telemetry/metrics.rs
+8 −2 core/src/telemetry/mod.rs
+1 −0 core/src/telemetry/prometheus_meter.rs
+7 −0 core/src/worker/mod.rs
+9 −0 core/src/worker/slot_provider.rs
+9 −2 core/src/worker/workflow/machines/patch_state_machine.rs
+5 −0 core/src/worker/workflow/machines/workflow_machines.rs
+8 −3 core/src/worker/workflow/workflow_stream.rs
+4 −5 sdk-core-protos/Cargo.toml
+10 −23 sdk-core-protos/build.rs
+9 −1 sdk-core-protos/protos/api_upstream/.github/workflows/create-release.yml
+254 −5 sdk-core-protos/protos/api_upstream/openapi/openapiv2.json
+234 −5 sdk-core-protos/protos/api_upstream/openapi/openapiv3.yaml
+1 −1 sdk-core-protos/protos/api_upstream/temporal/api/common/v1/message.proto
+6 −0 sdk-core-protos/protos/api_upstream/temporal/api/deployment/v1/message.proto
+6 −2 sdk-core-protos/protos/api_upstream/temporal/api/namespace/v1/message.proto
+60 −2 sdk-core-protos/protos/api_upstream/temporal/api/workflowservice/v1/request_response.proto
+30 −6 sdk-core-protos/protos/api_upstream/temporal/api/workflowservice/v1/service.proto
+2 −0 sdk-core-protos/protos/local/temporal/sdk/core/workflow_activation/workflow_activation.proto
+1 −1 sdk-core-protos/src/history_builder.rs
+6 −6 sdk-core-protos/src/lib.rs
+2 −5 sdk-core-protos/src/utilities.rs
+8 −2 sdk/Cargo.toml
+91 −1 tests/integ_tests/metrics_tests.rs
+10 −2 tests/integ_tests/workflow_tests/patches.rs
Loading
Loading