Skip to content

fix(tco): [121024828] group_type support optional #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix(tco): [121024828] group_type support optional #2992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c98b36
group_type support optional
Dec 3, 2024
9749ae5
update
Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/2992.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/tencentcloud_identity_center_group: `group_type` support optional
```
7 changes: 6 additions & 1 deletion tencentcloud/services/tco/resource_tc_identity_center_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ func ResourceTencentCloudIdentityCenterGroup() *schema.Resource {
},
"group_type": {
Type: schema.TypeString,
Optional: true,
Computed: true,
Description: "Type of user group. `Manual`: manual creation, `Synchronized`: external import.",
},
Expand Down Expand Up @@ -104,6 +105,10 @@ func resourceTencentCloudIdentityCenterGroupCreate(d *schema.ResourceData, meta
request.Description = helper.String(v.(string))
}

if v, ok := d.GetOk("group_type"); ok {
request.GroupType = helper.String(v.(string))
}

err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseOrganizationClient().CreateGroupWithContext(ctx, request)
if e != nil {
Expand Down Expand Up @@ -194,7 +199,7 @@ func resourceTencentCloudIdentityCenterGroupUpdate(d *schema.ResourceData, meta

ctx := tccommon.NewResourceLifeCycleHandleFuncContext(context.Background(), logId, d, meta)

immutableArgs := []string{"zone_id"}
immutableArgs := []string{"zone_id", "group_type"}
for _, v := range immutableArgs {
if d.HasChange(v) {
return fmt.Errorf("argument `%s` cannot be changed", v)
Expand Down
8 changes: 5 additions & 3 deletions tencentcloud/services/tco/resource_tc_identity_center_group_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func TestAccTencentCloudIdentityCenterGroupResource_basic(t *testing.T) {
resource.TestCheckResourceAttr("tencentcloud_identity_center_group.identity_center_group", "zone_id", "z-s64jh54hbcra"),
resource.TestCheckResourceAttr("tencentcloud_identity_center_group.identity_center_group", "group_name", "tf-test-group"),
resource.TestCheckResourceAttrSet("tencentcloud_identity_center_group.identity_center_group", "create_time"),
resource.TestCheckResourceAttrSet("tencentcloud_identity_center_group.identity_center_group", "group_type"),
resource.TestCheckResourceAttr("tencentcloud_identity_center_group.identity_center_group", "group_type", "Manual"),
resource.TestCheckResourceAttrSet("tencentcloud_identity_center_group.identity_center_group", "update_time"),
resource.TestCheckResourceAttrSet("tencentcloud_identity_center_group.identity_center_group", "group_id"),
resource.TestCheckResourceAttrSet("tencentcloud_identity_center_group.identity_center_group", "member_count"),
Expand All @@ -48,16 +48,18 @@ func TestAccTencentCloudIdentityCenterGroupResource_basic(t *testing.T) {

const testAccIdentityCenterGroup = `
resource "tencentcloud_identity_center_group" "identity_center_group" {
zone_id = "z-s64jh54hbcra"
zone_id = "z-s64jh54hbcra"
group_name = "tf-test-group"
description = "test"
group_type = "Manual"
}
`

const testAccIdentityCenterGroupUpdate = `
resource "tencentcloud_identity_center_group" "identity_center_group" {
zone_id = "z-s64jh54hbcra"
zone_id = "z-s64jh54hbcra"
group_name = "tf-test-group"
description = "test_update"
group_type = "Manual"
}
`
2 changes: 1 addition & 1 deletion website/docs/r/identity_center_group.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The following arguments are supported:
* `group_name` - (Required, String) The name of the user group. Format: Allow English letters, numbers and special characters-. Length: Maximum 128 characters.
* `zone_id` - (Required, String) Zone id.
* `description` - (Optional, String) A description of the user group. Length: Maximum 1024 characters.
* `group_type` - (Optional, String) Type of user group. `Manual`: manual creation, `Synchronized`: external import.

## Attributes Reference

Expand All @@ -36,7 +37,6 @@ In addition to all arguments above, the following attributes are exported:
* `id` - ID of the resource.
* `create_time` - Creation time of the user group.
* `group_id` - ID of the user group.
* `group_type` - Type of user group. `Manual`: manual creation, `Synchronized`: external import.
* `member_count` - Number of team members.
* `update_time` - Modification time for the user group.

Expand Down
Loading