feat: Add support for deployment_circuit_breaker configuration #425
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for the ECS deployment circuit breaker feature,
which allows for automatic rollback of failed deployments.
The deployment_circuit_breaker configuration is now passed through from
the service variable to the underlying ECS service module, enabling users
to configure automatic rollback behavior for their Atlantis deployments.
Example usage:
service = {
deployment_circuit_breaker = {
enable = true
rollback = true
}
}
Updated both example configurations (github-complete and github-separate)
to demonstrate the circuit breaker feature.
Tested locally by referencing the module and confirming the circuit
breaker configuration is properly applied to the ECS service.
willaustin
changed the title
Author
|
@antonbabenko could I get a review please? Thanks! |
3 tasks
Member
|
This PR is included in version 5.0.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for the ECS deployment circuit breaker feature, which allows for automatic rollback of failed deployments.
The deployment_circuit_breaker configuration is now passed through from the service variable to the underlying ECS service module, enabling users to configure automatic rollback behavior for their Atlantis deployments.
Example usage:
Tested locally by referencing the module and confirming the circuit breaker configuration is properly applied to the ECS service.
Motivation and Context
We need to be able to set this config on ECS Tasks.
Breaking Changes
No breaking changes as it uses a default blank object if not passed.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request