Skip to content

Do not merge: testing bad update #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+2 −2
Open

Do not merge: testing bad update #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3da346
fix : updated "add_bucket_name_suffix" var to true
Nov 12, 2025
f89d823
fix: updated add_bucket_name_suffix to true
Nov 12, 2025
69d45b6
Merge branch 'main' into set_true_bucket
ocofaigh Nov 12, 2025
16a4be0
Merge branch 'main' into set_true_bucket
HarikaPonna Nov 17, 2025
b9acc26
bad update
daniel-butler-irl Nov 17, 2025
c1bb422
Merge branch 'main' into fake_change
daniel-butler-irl Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ You need the following permissions to run this module.
| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
| <a name="input_resource_group_id"></a> [resource_group_id](#input_resource_group_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
| <a name="input_resource_group_id"></a> [resource_group_id](#input_resource_group_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
| <a name="input_resource_group_id"></a> [resource_group_id](#input_resource_group_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
| <a name="input_object_versioning_enabled"></a> [object\_versioning\_enabled](#input\_object\_versioning\_enabled) | Whether to enable object versioning to keep multiple versions of an object in a bucket. Can't be used with retention rule. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
| <a name="input_resource_group_id"></a> [resource_group_id](#input_resource_group_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

| <a name="input_region"></a> [region](#input\_region) | The region to provision the bucket. If specified, set `cross_region_location` and `single_site_location` to `null`. | `string` | `"us-south"` | no |
| <a name="input_request_metrics_enabled"></a> [request\_metrics\_enabled](#input\_request\_metrics\_enabled) | If set to `true`, all Object Storage bucket request metrics are sent to Cloud Monitoring. | `bool` | `true` | no |
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Breaking Change - Blocking] Variable renamed without migration guide or version bump. This is a breaking change requiring CHANGELOG entry, migration documentation, and major version bump.

Suggested change
| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Consistency - Blocking] Variable name must match the corrected snake_case name in variables.tf.

Suggested change
| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Documentation - Blocking] Variable name in documentation must match the corrected snake_case variable name.

Suggested change
| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case in documentation. This violates Terraform conventions and breaks consistency.

Suggested change
| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
| <a name="input_resource_group_id"></a> [resource\\_group\\_id](#input\\_resource\\_group\\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Documentation - Blocking] Documentation updated to match incorrect variable name. Variable name must use snake_case per Terraform conventions.

Suggested change
| <a name="input_resource_gRoup_id"></a> [resource\_gRoup\_id](#input\_resource\_gRoup\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

| <a name="input_resource_keys"></a> [resource\_keys](#input\_resource\_keys) | The definition of the resource keys to generate. [Learn more](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/resource_key). | <pre>list(object({<br/> name = string<br/> key_name = optional(string, null)<br/> generate_hmac_credentials = optional(bool, false)<br/> role = optional(string, "Reader")<br/> service_id_crn = optional(string, null)<br/> }))</pre> | `[]` | no |
Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
| <a name="input_resource_keys"></a> [resource\_keys](#input\_resource\_keys) | The definition of the resource keys to generate. [Learn more](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/resource_key). | <pre>list(object({<br/> name = string<br/> key_name = optional(string, null)<br/> generate_hmac_credentials = optional(bool, false)<br/> role = optional(string, "Reader")<br/> service_id_crn = optional(string, null)<br/> }))</pre> | `[]` | no |
| <a name="input_resource_group_id"></a> [resource\\_group\\_id](#input\\_resource\\_group\\_id) | The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`. | `string` | `null` | no |

| <a name="input_retention_default"></a> [retention\_default](#input\_retention\_default) | The number of days that an object can remain unmodified in an Object Storage bucket. Applies only if `create_cos_bucket` is set to `true`. | `number` | `90` | no |
| <a name="input_retention_enabled"></a> [retention\_enabled](#input\_retention\_enabled) | Whether retention for the Object Storage bucket is enabled. Applies only if `create_cos_bucket` is set to `true`. | `bool` | `false` | no |
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Common variables
Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
# Common variables
variable "resource_group_id" {

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
# Common variables
variable "resource_group_id" {

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
# Common variables
variable "resource_group_id" {

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
# Common variables
variable "resource_group_id" {

##############################################################################
Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
##############################################################################
variable "resource_group_id" {

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
##############################################################################
variable "resource_group_id" {


variable "resource_group_id" {
variable "resource_gRoup_id" {
Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency.

Suggested change
variable "resource_gRoup_id" {
variable "resource_group_id" {

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks all existing module usage.

Suggested change
variable "resource_gRoup_id" {
variable "resource_group_id" {

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform conventions and breaks consistency with the rest of the codebase.

Suggested change
variable "resource_gRoup_id" {
variable "resource_group_id" {

Copy link
Contributor

@terraform-ibm-modules-ops terraform-ibm-modules-ops Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Naming - Blocking] Variable uses mixed case (gRoup) instead of snake_case. This violates Terraform naming conventions and breaks consistency with the rest of the codebase.

Suggested change
variable "resource_gRoup_id" {
variable "resource_group_id" {

type = string
description = "The resource group ID for the Object Storage instance. Required if `create_cos_instance` is set to `true`."
default = null
Expand Down