feat: added lifecycle_rules submodule #999
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditya-ranjan-16
requested review from
maheshwarishikha and
shemau
as code owners
Contributor
Author
|
/run pipeline |
2 similar comments
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
shemau
requested changes
Nov 24, 2025
Comment on lines
+21
to
+25
| variable "object_versioning_enabled" { | ||
| description = "Whether to enable object versioning to keep multiple versions of an object in a bucket." | ||
| type = bool | ||
| default = false | ||
| } |
Contributor
There was a problem hiding this comment.
This does not do this. In fact this is not used in the code anywhere. It is only used in cross variable validation.
This is not a pattern used anywhere in the TIM, AFAIK.
| output, err := options.RunTestConsistency() | ||
| assert.Nil(t, err, "This should not have errored") | ||
| assert.NotNil(t, output, "Expected some output") | ||
| } |
Contributor
There was a problem hiding this comment.
PR tests cannot be overlooked for a whole module.
I think sufficient coverage would be to update the basic example to use the new module, the same way it validates the buckets module.
Extending the basic example would mean no need for any additional example code, or additional tests.
Ak-sky
reviewed
Nov 25, 2025
Member
There was a problem hiding this comment.
Why are we not adding archive rule as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new
lifecycle_rulessubmodule which allows to add multiple expiry lifecycle rules to an existing cos buckethttps://github.ibm.com/GoldenEye/issues/issues/15834
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR Adds a new
lifecycle_rulessubmodule which allows to add multiple expiry lifecycle rules to an existing cos bucketRun the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers