Template housekeeping - cleanup and fixes #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaliszS
requested changes
Nov 19, 2025
copier.yaml
Outdated
| when: "{{ project_type in ['api-monolith', 'api-microservice', 'agent'] }}" | ||
| - "uv sync" | ||
| - "uv sync && uv sync --group code-quality" | ||
| - "git init && git branch -M master && git checkout -b master && git add --all" |
Collaborator
There was a problem hiding this comment.
personally I love master as a default name, but I know github use main now. It's nothing that should be updated, but just wanted to spot this, so maybe it's worth to decide early on the branch name
| from enum import Enum | ||
| from functools import wraps | ||
| from typing import Any, Callable, Generator, Protocol | ||
| from typing import Any, Callable, Generator |
Collaborator
There was a problem hiding this comment.
we should add separate line: from collections.abc import Callable, Generator
It works right now, because typing is importing them internally, but this is not the place they are defined (Any is fine, should stay as imported from typing)
Contributor
Author
There was a problem hiding this comment.
Changed as per review
KaliszS
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of minor linting issues and conflicts, focused mostly on the monolith setup