-
Notifications
You must be signed in to change notification settings - Fork 15
Add 4 organization endpoints #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Eilandis
wants to merge
5
commits into
tizz98:main
Choose a base branch
from
qosenergy:clerk-sdk-python-fork
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a17cb72
[FIX] Add Content Type in the request headers.
09c7bf4
[IMP] Add clerk organizations types and CRUD endpoints.
3474740
Upgrades dependencies.
b2a16a0
Apply suggestions from code review
Eilandis ad223db
[FIX] Avoid one letter vars.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -137,3 +137,4 @@ dmypy.json | |
| # Cython debug symbols | ||
| cython_debug/ | ||
|
|
||
| *.idea | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from typing import List | ||
|
|
||
| from clerk import types | ||
| from clerk.client import Service | ||
|
|
||
|
|
||
| class OrganizationsService(Service): | ||
| endpoint = "organizations" | ||
|
|
||
| async def list(self) -> List[types.Organization]: | ||
| """Retrieve a list of all organizations""" | ||
| async with self._client.get(self.endpoint) as r: | ||
| s = await r.json() | ||
Eilandis marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return [types.Organization.parse_obj(s) for s in s.get("data")] | ||
Eilandis marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| async def get(self, organization_id: str) -> types.Organization: | ||
| """Retrieve an organization by their id""" | ||
| async with self._client.get(f"{self.endpoint}/{organization_id}") as r: | ||
| return types.Organization.parse_obj(await r.json()) | ||
|
|
||
| async def delete(self, organization_id: str) -> types.DeleteOrganizationResponse: | ||
| """Delete an organization by their id""" | ||
| async with self._client.delete(f"{self.endpoint}/{organization_id}") as r: | ||
| return types.DeleteOrganizationResponse.parse_obj(await r.json()) | ||
|
|
||
| async def update(self, organization_id: str, request: types.UpdateOrganizationRequest) -> types.Organization: | ||
| """Update an organization by their id""" | ||
| async with self._client.patch( | ||
| f"{self.endpoint}/{organization_id}", data=request.json(exclude_unset=True) | ||
| ) as r: | ||
| return types.Organization.parse_obj(await r.json()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use
respinstead ofrfor all of these methodsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the rest of the methods and make sure the code still works. There's still a reference to
srather thanresp_jsonUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, should have tested it.
Not a big user of one-letter vars myself, I kept them originally to be "coherent" with your methods in clients.py
I fixed this issues in my last commit.