[Bugfix] Fixes an off-by-one error in kshape. (Issue #385) #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s & Gravano uses MATLAB-style indexing on 1, instead of Python-style indexing on 0.)
Contributor
|
I've ported it to current codebase in #596... Hope you don't mind and thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem pointed out in issue #385. The original paper uses MATLAB-style indexing, i.e. starting on 1, as opposed to Python-style indexing starting on 0. Therefore there was a mismatch between tslearn and line 6, Algorithm 1 of that paper.
It should be noted that this indexing issue seems to be accounted for in this PR.