-
-
Notifications
You must be signed in to change notification settings - Fork 518
Switch Dependabot to Renovate #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Dependabot to Renovate #2893
Conversation
| "automerge": true, | ||
| "automergeType": "branch", | ||
| "schedule": ["* * * * 1"], | ||
| "automergeSchedule": ["* * * * 2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would update all unpinned dependencies in uv.lock once per week:
- Branch is created every Monday.
- If the branch build succeeded, Renovate will automatically merge it without a PR on Tuesday.
- If build failed, a PR will be opened with the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, packageRules can be used to configure similar automerge behavior for a wider range of packages.
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "dependencyDashboard": true, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is enabled, Renovate will maintain a GitHub issue about the status of various dependency updates, it can also be used to control its behavior via checkboxes. Example:
| push: | ||
| branches: | ||
| - master | ||
| - "renovate/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for Renovate "automerge" to be able to verify branch changes without a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes to double all our CI jobs, see #2898
It starts 83 checks :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point. There are two options:
- Configure GitHub Actions concurrency to terminate the branch job when PR job starts.
- Only whitelist
renovate/lock-file-maintenancefor the branch CI.
Option (2) looks simpler -- but the downside is that if we were to expand "automerge" to other package updates, then the list of branches needs updating manually.
ISTM that we actually could use automerge for most version bumps -- in those PRs we usually just check that CI is passing. So automation could save time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a PR for option (2) #2899
|
I'm +1 |
UnknownPlatypus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 for renovate, lgtm
|
@sobolevn don't forget you need to grant Renovate access to the repo also. https://developer.mend.io/github/typeddjango |
Follow-up to #2893 (comment) -- prevent unnecessary test runs in Renovate branches. Currently only "lock file maintenace" has automerge enabled, other Renovate branches will use PR tests not branch tests.
I already migrated
djangorestframework-stubsto Renovate and it's working fine. Though it did take me some time to get the configuration right for "automerge" of lock file maintenance.@sobolevn mentioned in typeddjango/djangorestframework-stubs#863 (comment) that
django-stubsalso has "problems with uv in django-stubs. dependabot does not even create PRs there". So this might resolve those.But for this to work, a maintainer with admin access (sobolevn) needs to enroll this repository at https://developer.mend.io/