test(server): add unit tests for extractActionCoords function in ActionCoordsTest
#2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @LeoColman! What's the motivation here? Are you planning to make some adjustments to the logic under test? I'm asking because I think we have good coverage of this part through the end-to-end tests (although I'd have to check when I'm by my laptop). For now just wanted to learn what triggered this PR 😁 |
Member
|
Ah, see it on Slack now, thanks! |
krzema12
requested changes
Nov 21, 2025
| class ActionCoordsTest : | ||
| FunSpec( | ||
| { | ||
| test("extractActionCoords parses owner/name with version and no path, FULL by default") { |
Member
There was a problem hiding this comment.
How about using context("extractActionCoords"), in case we need to add tests for some other function? Then we could remove the function name from individual test cases.
| test("extractActionCoords parses owner/name with version and no path, FULL by default") { | ||
| val parameters = createParameters(owner = "o", name = "act", version = "v1") | ||
|
|
||
| parameters.extractActionCoords(true) shouldBe |
Member
There was a problem hiding this comment.
In every test, let's used named arguments - extractActionCoords(true) doesn't look readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.