Merge pull request #1690 from ultraleap/mjp/make_outline_hands_outline_independent_of_normal_scale

Mjp/make outline hands outline independent of normal scale

Author: MaxPalmer-UH

Packages/Tracking/CHANGELOG.md

@@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Text on the toggle button in the UI Input example scene now shows On or Off based on the toggled state
 - Clients were not able to subscribe to the events on the PinchDetector and GrabDetector scripts as the properties were exposed as readonly. 
 - GrabDetector detection logic was inverted, so open hands were interpreted as grabs. Now fixed.
+- Fixed issue with scale of outline in GenericHandShader if hand model normals are not a normalized length 
 - Fixed issue with attachment hands red/green/blue materials meta file IDs clashing with the IDs of the files in the original examples, since being moved
 
 ### Known Issues

Packages/Tracking/Hands/Runtime/Shaders/BiRP and URP/GenericHandShader.shader

@@ -1,4 +1,4 @@
-Shader "Ultraleap/GenericHandShader"
+Shader "Ultraleap/GenericHandShader"
 {
     Properties
     {
@@ -349,7 +349,9 @@
 
                 #if _USEOUTLINE_ON
                 float3 norm = mul((float3x3)UNITY_MATRIX_IT_MV, v.normal);
-                float2 offset = TransformViewToProjection(norm.xy);
+                // Some hand models may include non normalized (length) normals, so we normalize the length of the normal first
+                float3 normalizedVector = normalize(norm);
+                float2 offset = TransformViewToProjection(normalizedVector.xy);
                 o.pos.xy += offset * _Outline;
                 #endif