Skip to content

Fix nested tool calls #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix nested tool calls #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/mcp_server_uyuni/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,9 @@ async def check_system_updates(system_identifier: Union[str, int], ctx: Context)
log_string = f"Checking pending updates for system {system_identifier}"
logger.info(log_string)
await ctx.info(log_string)
return await _check_system_updates(system_identifier, ctx)

async def _check_system_updates(system_identifier: Union[str, int], ctx: Context) -> Dict[str, Any]:
system_id = await _resolve_system_id(system_identifier)
default_error_response = {
'system_identifier': system_identifier,
Expand Down Expand Up @@ -456,7 +459,7 @@ async def check_system_updates(system_identifier: Union[str, int], ctx: Context)
unscheduled_errata_call
)
relevant_updates_list, unscheduled_updates_list = results

if not isinstance(relevant_updates_list, list) or not isinstance(unscheduled_updates_list, list):
logger.error(
f"API calls for system {system_id} did not return lists as expected. "
Expand Down Expand Up @@ -485,7 +488,7 @@ async def check_system_updates(system_identifier: Union[str, int], ctx: Context)
update_details['application_status'] = 'Pending'
else:
update_details['application_status'] = 'Queued'

# Initialize and fetch CVEs
update_details['cves'] = []
if advisory_name:
Expand Down Expand Up @@ -557,7 +560,7 @@ async def check_all_systems_for_updates(ctx: Context) -> List[Dict[str, Any]]:

print(f"Checking updates for system: {system_name} (ID: {system_id})")
# Use the existing check_system_updates tool
update_check_result = await check_system_updates(system_id, ctx)
update_check_result = await _check_system_updates(system_id, ctx)

if update_check_result.get('has_pending_updates', False):
# If the system has updates, add its info and update details to the result list
Expand Down Expand Up @@ -599,7 +602,7 @@ async def schedule_apply_pending_updates_to_system(system_identifier: Union[str,
return f"CONFIRMATION REQUIRED: This will apply pending updates to the system {system_identifier}. Do you confirm?"

# 1. Use check_system_updates to get relevant errata
update_info = await check_system_updates(system_identifier, ctx)
update_info = await _check_system_updates(system_identifier, ctx)

if not update_info or not update_info.get('has_pending_updates'):
print(f"No pending updates found for system {system_identifier}, or an error occurred while fetching update information.")
Expand Down