Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 6, 2025

Python 3.8 went end-of-life more than a year ago, and modern tools like pytest-run-parallel do not support it.

Copilot AI review requested due to automatic review settings November 6, 2025 12:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR drops support for Python 3.8, setting the minimum required Python version to 3.9. This aligns the project with Python 3.8's end-of-life status (October 2024).

  • Updated minimum Python version requirement from 3.8 to 3.9
  • Removed Python 3.8 from CI/CD test matrix
  • Updated documentation to reflect the new minimum version

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
setup.py Updated python_requires to >=3.9 and removed Python 3.8 classifier
README.md Updated requirements documentation to specify Python >= 3.9+
.github/workflows/integration.yaml Removed Python 3.8 and pypy-3.8 from test matrix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 6, 2025 12:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cclauss cclauss force-pushed the drop-python3.8 branch 2 times, most recently from 967113e to 682cb31 Compare November 6, 2025 13:07
Signed-off-by: Christian Clauss <cclauss@me.com>
Copilot AI review requested due to automatic review settings November 8, 2025 08:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkmkme mkmkme merged commit 4104da6 into valkey-io:main Nov 8, 2025
37 checks passed
@cclauss cclauss deleted the drop-python3.8 branch November 8, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants