Skip to content

Forced JSON mode on all models that support it. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Forced JSON mode on all models that support it. #57

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc62780
Forced JSON mode on all GPT-4 Turbo models newer than the 1106 preview.
lukehollenback Apr 2, 2024
fcc86cd
Forced JSON mode on newer GPT-3 Turbo models as well.
lukehollenback Apr 2, 2024
1eeb9e7
Future-proofed change by added regular GPT-4 Turbo model reference.
lukehollenback Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ async function getAIResponse(prompt: string): Promise<Array<{
const response = await openai.chat.completions.create({
...queryConfig,
// return JSON if the model supports it:
...(OPENAI_API_MODEL === "gpt-4-1106-preview"
...(OPENAI_API_MODEL === "gpt-4-turbo-preview" || OPENAI_API_MODEL === "gpt-4-turbo" || OPENAI_API_MODEL === "gpt-3.5-turbo" || OPENAI_API_MODEL === "gpt-4-0125-preview" || OPENAI_API_MODEL === "gpt-4-1106-preview" || OPENAI_API_MODEL === "gpt-3.5-turbo-0125" || OPENAI_API_MODEL === "gpt-3.5-turbo-1106"
Copy link
Owner

@villesau villesau Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this was a good catch! Where did you find the list? 🤔 Looks like most if not all the chat models are listed?

Copy link
Author

@lukehollenback lukehollenback Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a combination of information listed here, here, and here.

It is basically all of the current-version turbo models. The standard models (e.g., gpt-4) still do not support JSON mode.

? { response_format: { type: "json_object" } }
: {}),
messages: [
Expand Down