Skip to content

Conversation

@AlonKellner-RedHat
Copy link
Collaborator

@AlonKellner-RedHat AlonKellner-RedHat commented Oct 30, 2025

Summary

E2E tests which check basic GuideLLM functionality, using vLLM simulator.

Details

Test Plan

  • Local testing
  • GitHub action

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Copy link
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. It is fairly self-contained, so it shouldn't cause any issues as long as the tests aren't flaky. Just one blocker as discussed in the call.

Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small nits

@AlonKellner-RedHat
Copy link
Collaborator Author

@sjmonson I just straight up applied all of your suggestions.
@jaredoconnell I removed the now redundant aiologic dependency, and integrated tox-pdm with all tox based tests.
Anything else you want to tackle before we land this one?

Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit. Also needs signoff, E.g. git rebase --signoff main.

Signed-off-by: Alon Kellner <akellner@redhat.com>
@sjmonson sjmonson merged commit f59a60f into vllm-project:main Nov 6, 2025
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants