Skip to content

[Draft]remove computed_field from total_tokens #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Draft]remove computed_field from total_tokens #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d8723
remove computed_field from total_tokens
tukwila Nov 6, 2025
f81612b
fix ut failure
tukwila Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/guidellm/schemas/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import uuid
from typing import Any, Literal

from pydantic import Field, computed_field
from pydantic import Field

from guidellm.utils import StandardBaseDict, StandardBaseModel

Expand Down Expand Up @@ -157,7 +157,7 @@ class UsageMetrics(StandardBaseDict):
default=None, description="Number of audio bytes processed/generated."
)

@computed_field # type: ignore[misc]
# @computed_field # type: ignore[misc]
@property
def total_tokens(self) -> int | None:
"""
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def test_default_settings():
assert settings.openai == OpenAISettings()
assert (
settings.report_generation.source
== "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html"
== "https://blog.vllm.ai/guidellm/ui/v0.3.1/index.html"
)


Expand Down Expand Up @@ -60,13 +60,13 @@ def test_report_generation_default_source():
settings = Settings(env=Environment.STAGING)
assert (
settings.report_generation.source
== "https://blog.vllm.ai/guidellm/ui/release/v0.3.0/index.html"
== "https://blog.vllm.ai/guidellm/ui/release/v0.3.1/index.html"
)

settings = Settings(env=Environment.PROD)
assert (
settings.report_generation.source
== "https://blog.vllm.ai/guidellm/ui/v0.3.0/index.html"
== "https://blog.vllm.ai/guidellm/ui/v0.3.1/index.html"
)


Expand Down
Loading