Skip to content

[Deprecation] Remove Training Support #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 20, 2025
Merged

[Deprecation] Remove Training Support #2044

merged 24 commits into from
Nov 20, 2025
+90 −3,261

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Nov 18, 2025 •
edited
Loading

SUMMARY:

  • Remove all training support
  • Remove the distillation modifier and any related parsing
  • Move the data folder which was under finetune to be under the transformers folder
  • Extend base and pytorch testing to run on 3.10 and 3.13
  • Update transformers tests to run on Python 3.12
  • Updated examples/quantization_2of4_sparse_w4a16.py
  • Update the entrypoints README.md

Testing:

  • Nightly passes

@dsikka dsikka added the ready When a PR is ready for review label Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka changed the title remove training support Remove Training Support Nov 18, 2025
kylesayrs
kylesayrs previously approved these changes Nov 18, 2025
View reviewed changes
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will close #1895

@dsikka dsikka marked this pull request as ready for review November 19, 2025 18:28
@dsikka dsikka requested a review from kylesayrs November 19, 2025 18:29
@dsikka dsikka changed the title Remove Training Support [Deprecation] Remove Training Support Nov 19, 2025
kylesayrs
kylesayrs reviewed Nov 19, 2025
View reviewed changes
@kylesayrs
Copy link
Collaborator

kylesayrs commented Nov 20, 2025

Also, we should get rid of training callbacks and events (later)

@dsikka
Copy link
Collaborator Author

dsikka commented Nov 20, 2025

Also, we should get rid of training callbacks and events (later)

I thought I got them? Can you link what I missed

HDCharles
HDCharles approved these changes Nov 20, 2025
View reviewed changes
Copy link
Collaborator

@HDCharles HDCharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The greatest achievements are born from the greatest sacrifice

@dsikka dsikka merged commit 9cb1c6d into main Nov 20, 2025
11 checks passed
@dsikka dsikka deleted the rm_training branch November 20, 2025 14:40
@rahul-tuli
Copy link
Collaborator

rahul-tuli commented Nov 20, 2025

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylesayrs kylesayrs kylesayrs approved these changes

@HDCharles HDCharles HDCharles approved these changes

Assignees

No one assigned

Labels

ready When a PR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dsikka @kylesayrs @rahul-tuli @HDCharles