-
Notifications
You must be signed in to change notification settings - Fork 294
[docs] Add autoround doc #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add autoround doc #2055
Conversation
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @yiliu30, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive documentation for the AutoRound quantization technique within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the AutoRound quantization method. It includes an update to the main compression guide and a new detailed README.md for the autoround example. The documentation is well-written and provides a good walkthrough for users. I've identified a couple of minor issues in the new README.md file related to a dependency version and a typo in a scheme name, which could cause confusion or errors for users. Once these are addressed, the documentation will be in great shape.
|
@dsikka @kylesayrs @brian-dellabetta please help review. Thanks. |
…ssor-fork into autoround-doc Signed-off-by: yiliu30 <yi4.liu@intel.com>
dsikka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. do you mind adding a small blurb to our repo readme as well, under the What's New section?
kylesayrs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Will do. Thanks for your suggestion! |
Signed-off-by: yiliu30 <yi4.liu@intel.com>
Updated! Please take a look when you have a chance, thanks! |
The follow-up on #1994
The rendered version:
https://github.com/yiliu30/llm-compressor-fork/blob/autoround-doc/README.md
https://github.com/yiliu30/llm-compressor-fork/tree/autoround-doc/examples/autoround
https://github.com/yiliu30/llm-compressor-fork/blob/autoround-doc/docs/getting-started/compress.md
cc @hshen14 @thuang6 @wenhuach21