Skip to content

Commit 7a45d49

Browse files
committed
add default feature in generate support matrices (#1026)
Signed-off-by: Teresa Chen <boe20211@gmail.com>
1 parent 969a99b commit 7a45d49

10 files changed

+10
-51
lines changed

.buildkite/features/Multimodal_Inputs.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ steps:
66
agents:
77
queue: tpu_v6e_queue
88
commands:
9-
- echo "for test"
9+
- .buildkite/scripts/run_in_docker.sh python3 -m pytest -s -v /workspace/vllm/tests/v1/tpu/test_multimodal.py
1010
- label: "Record correctness test result for Multimodal Inputs"
1111
key: "record_Multimodal_Inputs_CorrectnessTest"
1212
depends_on: "Multimodal_Inputs_CorrectnessTest"
@@ -26,7 +26,7 @@ steps:
2626
agents:
2727
queue: tpu_v6e_queue
2828
commands:
29-
- echo "for test"
29+
- .buildkite/scripts/run_in_docker.sh bash /workspace/tpu_inference/tests/e2e/benchmarking/mm_bench.sh
3030
- label: "Record performance test result for Multimodal Inputs"
3131
key: "record_Multimodal_Inputs_PerformanceTest"
3232
depends_on: "Multimodal_Inputs_PerformanceTest"

.buildkite/features_skip/Multimodal_Inputs.yml

Lines changed: 0 additions & 40 deletions
This file was deleted.

.buildkite/features_skip/default_features.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

.buildkite/scripts/generate_support_matrices.sh

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ else
3030
fi
3131

3232
process_models() {
33+
local row
34+
local result
3335
for model in "${model_list[@]:-}"; do
3436
row="\"$model\""
3537
for stage in "${MODEL_STAGES[@]}"; do
@@ -45,36 +47,37 @@ process_models() {
4547

4648
process_features() {
4749
declare -A feature_rows
48-
50+
local result
51+
# Process features from the default list
4952
for feature in "${default_feature_list[@]:-}"; do
5053
if [[ -z "$feature" ]]; then continue; fi
5154
local row="\"$feature\""
5255
for stage in "${FEATURE_STAGES[@]}"; do
53-
local result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "")
56+
result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "")
5457
row="$row,$result"
5558
if [ "${result}" != "" ] && [ "${result}" != "N/A" ] ; then
5659
ANY_FAILED=true
5760
fi
5861
done
5962
feature_rows["$feature"]="$row"
6063
done
61-
64+
# Process features from the metadata list
6265
for feature in "${metadata_feature_list[@]:-}"; do
6366
if [[ -z "$feature" ]]; then continue; fi
6467
if [[ -v feature_rows["$feature"] ]]; then
6568
continue
6669
fi
6770
local row="\"$feature\""
6871
for stage in "${FEATURE_STAGES[@]}"; do
69-
local result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "N/A")
72+
result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "N/A")
7073
row="$row,$result"
7174
if [ "${result}" != "" ] && [ "${result}" != "N/A" ] ; then
7275
ANY_FAILED=true
7376
fi
7477
done
7578
feature_rows["$feature"]="$row"
7679
done
77-
80+
# Output all unique rows, sorted, to the CSV file
7881
for row in "${feature_rows[@]}"; do
7982
echo "$row"
8083
done | sort -V >> "$feature_support_matrix_csv"

0 commit comments

Comments
 (0)