Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Nov 21, 2025

What this PR does / why we need it?

When we are using pip install -e ., the entrypoint is pyproject.toml, but there exist an issue toml section missing PosixPath('pyproject.toml') does not contain a tool.setuptools_scm section when using using setuptools_scm and section:[tool.setuptools_scm] is miss, fix https://github.com/vllm-project/vllm-ascend/actions/runs/19548410938/job/55973159872

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: wangli <wangli858794774@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a build error that occurs with pip install -e . by adding the necessary [tool.setuptools_scm] section to the pyproject.toml file. The change is straightforward, correct, and effectively resolves the described issue.

@Potabk Potabk added ready-for-test start test by label for PR performance-test enable performance test for PR labels Nov 21, 2025
Signed-off-by: wangli <wangli858794774@gmail.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Signed-off-by: wangli <wangli858794774@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance-test enable performance test for PR ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant