Fix the hang issue of multimodal model when running with DP>1 and cudagraph_mode is FULL_DECODE_ONLY #4361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
When
cudagraph_modeis set to FULL_DECODE_ONLY, if dp > 1, the dummy-run process will be triggered. When calling theupdate_attn_paramsfunction, thenum_tokensparameter needs to be passed, and this value is obtained throughpositions.shape[0]. However, the multimodal model uses mRope (multi-dimensional rotary positional embeddings), which causes the shape ofpositionsto be 2. As a result, the value obtained frompositions.shape[0]is incorrect. We solve this problem by replacingpositions.shape[0]withnum_tokens.Does this PR introduce any user-facing change?
NO
How was this patch tested?
vLLM version: v0.11.0rc3
vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0