Skip to content

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Nov 8, 2025

Purpose

fixed the python version in pip-compile also fix a dep version

Fixes #28338

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 requested a review from hmellor as a code owner November 8, 2025 03:37
@mergify mergify bot added the ci/build label Nov 8, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue by pinning the Python version to 3.13 for pip-compile. While this ensures reproducible dependency generation, it hardcodes the version and can lead to broken builds for developers and CI pipelines using other supported Python versions. My review includes a suggestion to make this version dependency explicit by renaming the output requirements file, which would improve maintainability and prevent compatibility issues.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@noooop
Copy link
Collaborator

noooop commented Nov 8, 2025

cc @hmellor

@hmellor
Copy link
Member

hmellor commented Nov 8, 2025

I didn't realise the python version argument had been removed. Thanks for finding this. The version used should be the same as in the Dockerfile we use for CI, which I believe is 3.12

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: pre-commit all files failed for 3.14

3 participants