-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
fix: close issue 28338 by fixed python version #28339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an issue by pinning the Python version to 3.13 for pip-compile. While this ensures reproducible dependency generation, it hardcodes the version and can lead to broken builds for developers and CI pipelines using other supported Python versions. My review includes a suggestion to make this version dependency explicit by renaming the output requirements file, which would improve maintainability and prevent compatibility issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
cc @hmellor |
|
I didn't realise the python version argument had been removed. Thanks for finding this. The version used should be the same as in the Dockerfile we use for CI, which I believe is 3.12 |
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
Purpose
fixed the python version in pip-compile also fix a dep version
Fixes #28338
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.