-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
[Kernel] Fix fused_gdn_gating #28343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an accuracy issue in the fused_gdn_gating_kernel. The changes are twofold: first, the manual sigmoid implementation is replaced with tl.sigmoid, which should provide better numerical stability. Second, the data type for storing the beta_output is corrected to match the input tensor b's data type. This change ensures that the kernel's behavior correctly mimics b.sigmoid(), resolving a precision mismatch that was likely the cause of the accuracy problem. The fix appears correct and well-targeted. I have no further suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Could you add accuracy test before this PR |
Before this PR, sometimes gsm8k score was zero |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
what sometimes exactly mean?
|
same cmd, randomly 0 or around .80 |
Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
Fix fused_gdn_gating accuracy issue
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.