Skip to content

Conversation

@mmangkad
Copy link
Contributor

@mmangkad mmangkad commented Nov 8, 2025

Purpose

Now that #27840 is merged, can we also revert gpt-oss max cudagraph size to 1024? Basically reverts #25508.

cc @mgoin

Test Plan

Tested

Test Result

Works


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the max_cudagraph_capture_size for gpt-oss from 992 back to 1024, which is a good performance improvement. The changes are correct, including the updated calculation for the number of CUDA graphs. I have one suggestion to improve code maintainability by removing an outdated FIXME comment.

Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this should be reasonable if the restriction is lifted now, thanks! cc @nvpohanh for the gpt-oss config update

@github-project-automation github-project-automation bot moved this from To Triage to Ready in gpt-oss Issues & Enhancements Nov 8, 2025
@mgoin mgoin added performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed labels Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gpt-oss Related to GPT-OSS models performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

2 participants