Skip to content

fix(ssr): filter out transition-specific props to avoid invalid HTML attributes #13894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix(ssr): filter out transition-specific props to avoid invalid HTML attributes #13894

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f32d148
fix(TransitionGroup): filter out transition-specific props to avoid i…
ZKunZhang Sep 15, 2025
92e31b0
Merge branch 'vuejs:main' into fix/transition-group-props-filtering
ZKunZhang Sep 15, 2025
2a13148
fix(TransitionGroup): 使用 hasOwn 函数优化属性过滤逻辑
ZKunZhang Sep 16, 2025
ba3ac8a
Merge branch 'fix/transition-group-props-filtering' of https://github…
ZKunZhang Sep 16, 2025
d65747a
fix(TransitionGroup): filter private props to avoid invalid HTML attr…
ZKunZhang Sep 18, 2025
ca7407e
fix(compiler-ssr): filter out all transition-specific props in Transi…
ZKunZhang Sep 18, 2025
81615a2
refactor: update comments to English (previously Chinese)
ZKunZhang Sep 18, 2025
a324b4e
refactor(TransitionGroup): improve props handling and filtering
ZKunZhang Sep 18, 2025
a64f7f3
refactor(TransitionGroup): from main branchprocess for TransitionGroup
ZKunZhang Sep 19, 2025
9f665ff
fix(compiler-ssr): filter v-bind object props in TransitionGroup SSR …
ZKunZhang Sep 23, 2025
bf98abe
fix(compiler-ssr): runtime filter for v-bind object in TransitionGrou…
ZKunZhang Sep 23, 2025
5590203
fix(compiler-ssr): runtime filter transition props in TransitionGroup…
ZKunZhang Sep 23, 2025
2a477e8
fix(compiler-ssr): runtime filter transition props in TransitionGroup…
ZKunZhang Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/runtime-dom/src/components/TransitionGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,19 @@ const TransitionGroupImpl: ComponentOptions = /*@__PURE__*/ decorate({
tag = 'span'
}

// Filter out transition-specific props and TransitionGroup-specific props
// to avoid invalid HTML attributes
const filteredProps: Record<string, any> = {}
for (const key in rawProps) {
if (
!(key in TransitionPropsValidators) &&
key !== 'tag' &&
key !== 'moveClass'
) {
filteredProps[key] = (rawProps as any)[key]
}
}

prevChildren = []
if (children) {
for (let i = 0; i < children.length; i++) {
Expand Down Expand Up @@ -167,7 +180,7 @@ const TransitionGroupImpl: ComponentOptions = /*@__PURE__*/ decorate({
}
}

return createVNode(tag, null, children)
return createVNode(tag, filteredProps, children)
}
},
})
Expand Down