Do not remove the race response map entry in Lookup Race Response #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
annevk
approved these changes
Nov 21, 2025
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
s/de-deprecating/de-duplicating/ presumably?
I also wouldn't call this map entry removal redundant as it has a different effect.
Looks good otherwise.
Collaborator
|
It is totally fine for me either to remove or not (use once or multiple times). I will wait for the description update. |
yoshisatoyanagisawa
approved these changes
Nov 21, 2025
Contributor
Author
|
Thank you! Updated the description. I'll add the test soon to ensure this behavior. |
github-actions bot
added a commit
that referenced
this pull request
Nov 26, 2025
) SHA: a6ed7c8 Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Nov 26, 2025
github-actions bot
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is based on the discussion in whatwg/fetch#1737. We don't have to remove the entry from the race response map in the lookup-race-response-algorithm, as we don't want to limit de-duplicating the fetch(e.request) call once triggered in the fetch handler. fetch(e.request) can be called multiple times in one fetch handler.
The map entry is removed in the step 20 of the Create Fetch Event and Dispatch. That ensures that the added entry is removed.
Preview | Diff