Skip to content

fix： OkHttp response body is not being closed #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix： OkHttp response body is not being closed #291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9047e9d
fix： OkHttp response body is not being closed
imyuyu Aug 15, 2024
1f04125
Merge pull request #1 from wechatpay-apiv3/main
imyuyu Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/src/main/java/com/wechat/pay/java/core/http/okhttp/OkHttpClientAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,7 @@ private OriginalResponse assembleOriginalResponse(
@Override
protected InputStream innerDownload(HttpRequest httpRequest) {
Request okHttpRequest = buildOkHttpRequest(httpRequest);
try {
Response okHttpResponse = okHttpClient.newCall(okHttpRequest).execute();
try (Response okHttpResponse = okHttpClient.newCall(okHttpRequest).execute()) {
if (isInvalidHttpCode(okHttpResponse.code())) {
throw new ServiceException(httpRequest, okHttpResponse.code(), "");
}
Expand Down