initialize values used by unsigned bin #9173
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlm2002
force-pushed
the
uninitVar_codeSonar
branch
from
8c79baa to
29e0af3
Compare
Contributor
Author
|
Retest this please Jenkins: java.io.StreamCorruptedException and Timeout |
dgarske
requested changes
Sep 9, 2025
rlm2002
force-pushed
the
uninitVar_codeSonar
branch
from
453ca66 to
8e91e6a
Compare
SparkiDev
requested changes
Sep 9, 2025
| a->dp[j++] = *(sp_int_digit*)(in + i - (SP_WORD_SIZEOF - 1)); | ||
| } | ||
| #else | ||
| for (i = 0; i < (int)a->used; i++) { |
Contributor
There was a problem hiding this comment.
Don't want to do this.
We are reading in bytes to create digits and the used will be updated to the length of the created digits.
Need to analyse the problem more deeply.
Contributor
Author
There was a problem hiding this comment.
Got it. Going back to the drawing board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds loop to initialize
a->dp[i]to 0 insp_read_unsigned_bin()fora->used.Testing
./configure && make check