fixed oss-fuzz warnings #9386
Open
fixed oss-fuzz warnings #9386
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Retest this please Jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two arrays of potentially uninitialized memory causing issues with oss-fuzz:
Uninitialized values in the newly allocated output buffer were being seen as a problem so I XMEMSET the buffer to 0. I also decided to set the align bytes to 0 in case that was throwing the fuzzer off.
The XMEMSET for hmac, in internal.c, enforces that the result array does not contribute garbage data to the final hashed value.
Fixes oss-fuzz issue 442261624.
Testing
Using the oss-fuzz reproduction steps.
Ran a
make checkin wolfssl with the default configuration.Checklist