refactor: Organize editor setup #242
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to environment setup.
Improve readability.
Use consistent terms between functions and comments.
Simplify `setUpEditorEnvironment` logic to improve readability.
This modules does not reference `window.wp` globals other than those loaded by the `wordpress-i18n` module via the script tag in the entry `index.html` file.
Reduce duplication.
This utility is solely used to await the availability of the bridge configuration. The value itself is retrieved via `getGBKit()`.
Node.js ESM stictly follows the ECMAScript spec, which requires module file endings. Vite, however, is more forgiving. We could consider updating all project imports for consistency.
dcalhoun
force-pushed
the
refactor/organize-editor-setup
branch
from
6b6532b to
c5c8bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Organize editor setup logic.
Why?
Reduce duplication. Improve readability.
How?
Testing Instructions
Smoke test the editor.
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.