test for invalid reassign #28404
test for invalid reassign #28404
Conversation
|
⚪
🟢 |
|
⚪
🟢 |
|
🟢 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new unit test TestReassignNonexistentTablet to verify that attempting to reassign a non-existent tablet is handled gracefully and does not block the Hive balancer.
- Adds test for reassigning a non-existent tablet via HTTP API
- Verifies that the invalid reassignment returns
total=0in the response - Ensures the balancer continues to operate normally after the invalid request
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| THolder<TEvHive::TEvTabletMetrics> metrics = MakeHolder<TEvHive::TEvTabletMetrics>(); | ||
| NKikimrHive::TTabletMetrics* metric = metrics->Record.AddTabletMetrics(); | ||
| metric->SetTabletID(tablet); | ||
| metric->MutableResourceUsage()->SetNetwork(9000); | ||
|
|
||
| runtime.SendToPipe(hiveTablet, sender, metrics.Release()); | ||
| } |
There was a problem hiding this comment.
Inconsistent indentation: this opening brace uses 7 spaces instead of 8 spaces like the rest of the function. Should align with the opening brace on line 8254.
| { | |
| THolder<TEvHive::TEvTabletMetrics> metrics = MakeHolder<TEvHive::TEvTabletMetrics>(); | |
| NKikimrHive::TTabletMetrics* metric = metrics->Record.AddTabletMetrics(); | |
| metric->SetTabletID(tablet); | |
| metric->MutableResourceUsage()->SetNetwork(9000); | |
| runtime.SendToPipe(hiveTablet, sender, metrics.Release()); | |
| } | |
| { | |
| THolder<TEvHive::TEvTabletMetrics> metrics = MakeHolder<TEvHive::TEvTabletMetrics>(); | |
| NKikimrHive::TTabletMetrics* metric = metrics->Record.AddTabletMetrics(); | |
| metric->SetTabletID(tablet); | |
| metric->MutableResourceUsage()->SetNetwork(9000); | |
| runtime.SendToPipe(hiveTablet, sender, metrics.Release()); | |
| } |
| metric->MutableResourceUsage()->SetNetwork(9000); | ||
|
|
||
| runtime.SendToPipe(hiveTablet, sender, metrics.Release()); | ||
| } |
There was a problem hiding this comment.
Inconsistent indentation: this closing brace uses 7 spaces instead of 8 spaces like the rest of the function. Should align with the corresponding opening brace.
| } | |
| } |
| { | ||
| THolder<TEvHive::TEvTabletMetrics> metrics = MakeHolder<TEvHive::TEvTabletMetrics>(); | ||
| NKikimrHive::TTabletMetrics* metric = metrics->Record.AddTabletMetrics(); | ||
| metric->SetTabletID(tablet); | ||
| metric->MutableResourceUsage()->SetNetwork(9000); | ||
|
|
||
| runtime.SendToPipe(hiveTablet, sender, metrics.Release()); | ||
| } | ||
|
|
||
| { | ||
| TDispatchOptions options; | ||
| options.FinalEvents.push_back(NHive::TEvPrivate::EvBalancerOut); | ||
| runtime.DispatchEvents(options); | ||
| } |
There was a problem hiding this comment.
Inconsistent indentation: this block uses 7 spaces instead of 8 spaces like the rest of the function. All lines in this block should be indented with 8 spaces to match the rest of the test function.
| { | |
| THolder<TEvHive::TEvTabletMetrics> metrics = MakeHolder<TEvHive::TEvTabletMetrics>(); | |
| NKikimrHive::TTabletMetrics* metric = metrics->Record.AddTabletMetrics(); | |
| metric->SetTabletID(tablet); | |
| metric->MutableResourceUsage()->SetNetwork(9000); | |
| runtime.SendToPipe(hiveTablet, sender, metrics.Release()); | |
| } | |
| { | |
| TDispatchOptions options; | |
| options.FinalEvents.push_back(NHive::TEvPrivate::EvBalancerOut); | |
| runtime.DispatchEvents(options); | |
| } | |
| { | |
| THolder<TEvHive::TEvTabletMetrics> metrics = MakeHolder<TEvHive::TEvTabletMetrics>(); | |
| NKikimrHive::TTabletMetrics* metric = metrics->Record.AddTabletMetrics(); | |
| metric->SetTabletID(tablet); | |
| metric->MutableResourceUsage()->SetNetwork(9000); | |
| runtime.SendToPipe(hiveTablet, sender, metrics.Release()); | |
| } | |
| { | |
| TDispatchOptions options; | |
| options.FinalEvents.push_back(NHive::TEvPrivate::EvBalancerOut); | |
| runtime.DispatchEvents(options); | |
| } |
| p2->SetValue("ReassignTablet"); | ||
| auto* p3 = pb.AddQueryParams(); | ||
| p3->SetKey("tablet"); | ||
| p3->SetValue("52"); |
There was a problem hiding this comment.
The hardcoded tablet ID "52" could potentially collide with an existing tablet. Consider using a clearly non-existent ID similar to line 8214 (e.g., TStringBuilder() << 0xfa5e7ab1e7) or adding a comment explaining why this specific value is guaranteed to be non-existent.
| p3->SetValue("52"); | |
| p3->SetValue(TStringBuilder() << 0xfa5e7ab1e7); |
|
@vporyadke привяжи issue и свяжи с pr, в котором делалось исправление. |
2 participants
Changelog entry
...
Changelog category
Description for reviewers
...