-
Notifications
You must be signed in to change notification settings - Fork 733
fix: schema version handling #28418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: schema version handling #28418
Conversation
|
🟢 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7f3bc9a to
f0a04ef
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors and enhances the version synchronization logic for continuous backup CDC streams, particularly for tables with indexes. The refactoring extracts inline logic into separate functions and adds support for syncing index entity versions during continuous backup operations.
- Introduces a new
PersistTableIndexAlterVersionfunction to persist index alter versions to the database - Refactors version synchronization logic into dedicated helper functions with improved structure and logging
- Adds a test case for CDC version synchronization with multiple tables and indexes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/core/tx/schemeshard/schemeshard_impl.h | Declares new PersistTableIndexAlterVersion function for persisting index alter versions |
| ydb/core/tx/schemeshard/schemeshard_impl.cpp | Implements the new persistence function for table index alter versions |
| ydb/core/tx/schemeshard/schemeshard__operation_common_cdc_stream.cpp | Refactors version synchronization logic into helper functions and adds support for syncing child indexes during continuous backup operations |
| ydb/core/tx/datashard/datashard_ut_incremental_backup.cpp | Adds a new test case CdcVersionSync for testing continuous backup with multiple indexed tables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (versionCtx.IsPartOfContinuousBackup && versionCtx.IsIndexImplTable && | ||
| versionCtx.GrandParentPathId && context.SS->Tables.contains(versionCtx.GrandParentPathId)) { |
Copilot
AI
Nov 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The condition on line 208-209 is complex with multiple boolean checks. Consider extracting this into a descriptive helper function like ShouldSyncWithParentTable to improve readability and maintainability.
Changelog entry
...
Changelog category
Description for reviewers
...