Skip to content

Fix ES exception when a field missed in using updateAllCounters. #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ES exception when a field missed in using updateAllCounters. #334

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25dd79a
Fix ES exception when a field missed in using `updateAllCounters`.
jafaripur Jun 3, 2023
befeb31
Update ActiveRecord.php
samdark Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ActiveRecord.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public function getPrimaryKey($asArray = false)
* @param mixed $value
* @throws \yii\base\InvalidCallException when record is not new
* @deprecated since 2.1.0
*/
*/0
public function setPrimaryKey($value)
{
$pk = static::primaryKey()[0];
Expand Down Expand Up @@ -720,7 +720,7 @@ public static function updateAllCounters($counters, $condition = [])
foreach ($primaryKeys as $pk) {
$script = '';
foreach ($counters as $counter => $value) {
$script .= "ctx._source.{$counter} += params.{$counter};\n";
$script .= "ctx._source.{$counter} = (ctx._source.{$counter} == null ? 0 : ctx._source.{$counter}) + params.{$counter};\n";
}
$bulkCommand->addAction(["update" => ["_id" => $pk]], [
'script' => [
Expand Down