Skip to content

Conversation

@a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Sep 11, 2025

Description

  • Adds info about how many images have been pulled and will be pulled (wip)
  • Adds info about how many sboms need to be created for images/files (done)
  • Adds info about how many images have been pushed and will be pushed (wip)

Related Issue

Fixes #4169

Checklist before merging

@netlify
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit f759056
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68f1752dcae4f80008662a01

@brandtkeller
Copy link
Member

I don't see any issue with additional logging - looking forward to UX improvements.

@a1994sc
Copy link
Contributor Author

a1994sc commented Sep 18, 2025

Aside from bandwidth to actually do the work, I was wonder if get a "sanity" check:

So I would like to add the count to this section on pulling/saving the image for package:

l.Info("saving image", "name", imageInfo.registryOverrideRef, "size", utils.ByteFormat(float64(imageInfo.byteSize), 2))

However, that is encapsulated inside its own function, do I'm sure if it would ok to pass the count and size int into function for UX:

func orasSave(ctx context.Context, imageInfo imagePullInfo, cfg PullConfig, dst *oci.Store, client *auth.Client) error {

Thoughts?

Signed-off-by: Allen Conlon <software@conlon.dev>
@brandtkeller brandtkeller moved this to Ready in Zarf Oct 24, 2025
@brandtkeller brandtkeller moved this from Ready to In progress in Zarf Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Info tracker for artifacts pulled and overall count/length

2 participants