Helm 4

[AustinAbro321]

Description

We will have to be very careful about merging this as there may be impacts to charts that we do not test for in the migration from Helm 3 to Helm 4. We want the experience to be seamless for users.

Something interesting is that server side apply default to true during new installs, but "auto" during upgrades and rollbacks meaning that existing charts will use the existing strategy. Some consideration to if we would like to expose the server-side variable as part of the chart schema

zarf dev find-images and zarf dev inspect manifests no longer include files in tests. I am having trouble figuring out why. Generally I think this is a good thing, since Zarf doesn't have a way to run these tests. Would like to understand though

Related Issue

Fixes #2818
Fixes #2756

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[netlify]

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	ec58c93
🔍 Latest deploy log	https://app.netlify.com/projects/zarf-docs/deploys/690e5cf5b6a51c00085fd224

[codecov]

Codecov Report

❌ Patch coverage is 13.43284% with 116 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/internal/packager/helm/chart.go	1.42%	69 Missing ⚠️
src/internal/packager/helm/repo.go	8.33%	11 Missing ⚠️
src/internal/packager/helm/destroy.go	0.00%	8 Missing ⚠️
src/internal/packager/helm/zarf.go	0.00%	7 Missing ⚠️
src/pkg/packager/inspect.go	14.28%	6 Missing ⚠️
src/internal/packager/helm/common.go	50.00%	5 Missing ⚠️
src/internal/packager/helm/template.go	50.00%	3 Missing and 1 partial ⚠️
src/cmd/helm.go	33.33%	2 Missing ⚠️
src/internal/packager/helm/images.go	71.42%	2 Missing ⚠️
src/pkg/packager/remove.go	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/internal/packager/helm/post-render.go	0.00% <ø> (ø)
src/cmd/helm.go	66.66% <33.33%> (-15.69%)	⬇️
src/internal/packager/helm/images.go	79.16% <71.42%> (ø)
src/pkg/packager/remove.go	0.00% <0.00%> (ø)
src/internal/packager/helm/template.go	55.31% <50.00%> (-1.83%)	⬇️
src/internal/packager/helm/common.go	34.09% <50.00%> (-0.75%)	⬇️
src/pkg/packager/inspect.go	12.91% <14.28%> (ø)
src/internal/packager/helm/zarf.go	0.00% <0.00%> (ø)
src/internal/packager/helm/destroy.go	0.00% <0.00%> (ø)
src/internal/packager/helm/repo.go	23.59% <8.33%> (-0.17%)	⬇️
... and 1 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.