boards: arduino: add ADC support for the Nano Matter #99210
Conversation
silabs-bozont
force-pushed
the
main
branch
2 times, most recently
from
6ff6689 to
565c6ff
Compare
Adds ADC capability to the A0-A7 pins on the board. Signed-off-by: Tamas Jozsi <tamas.jozsi@silabs.com>
|
pillo79
left a comment
pillo79
left a comment
There was a problem hiding this comment.
LGTM and thanks, just a minor fix request!
| zephyr,user { | ||
| io-channels = <&adc0 0>, | ||
| <&adc0 1>, | ||
| <&adc0 2>, | ||
| <&adc0 3>, | ||
| <&adc0 4>, | ||
| <&adc0 5>, | ||
| <&adc0 6>, | ||
| <&adc0 7>; | ||
| }; |
There was a problem hiding this comment.
I guess this is Arduino-specific. It should be moved to the variant overlay in arduino/ArduinoCore-zephyr#255 (or a separate PR).
There was a problem hiding this comment.
I've included it here so users can get an enumeration of io-channels even outside of the Arduino Core, because the hardware is the same. Also other Silabs boards include these like here. If you have a strong opinion against including this here, I'm open to debate :)
Edit: I don't think io-channels is Arduino specific - it has many occurrences in this repo too.
There was a problem hiding this comment.
Oh, I thought having board-defined zephyr,user was verboten in Zephyr. Nevermind then! 🙂
3 participants
This PR adds ADC support for the Arduino Nano Matter on its analog pins A0-A7.