-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[bsp][renesas] Add ra8p1-titan-board BSP #11000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: bsp_renesasReviewers: @kurisaW Changed Files (Click to expand)
🏷️ Tag: workflowReviewers: @Rbb666 @kurisaW @supperthomas Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-01 18:58 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds BSP support for the Renesas RA8P1 Titan Board to RT-Thread, including LVGL integration with Arm-2D acceleration library for enhanced graphics performance.
Reviewed changes
Copilot reviewed 74 out of 602 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Source/*.inc | Arm-2D library C template files for tile operations with masking and mirroring |
| bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Source/*.c | Arm-2D implementation files for color conversion and filling operations |
| bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/Include/*.h | Arm-2D header files including configuration, utilities, and architecture port |
| bsp/renesas/ra8p1-titan-board/board/lvgl/arm-2d/SConscript | Build script for Arm-2D library integration |
| bsp/renesas/ra8p1-titan-board/board/lvgl/SConscript | Main LVGL build script |
| #include "__arm_2d_meta_fill_with_des_mask_and_mirror.inc" | ||
|
|
||
| /*----------------------------------------------------------------------------* | ||
| * fill with x-miorro * |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'
| * fill with x-miorro * | |
| * fill with x-mirror * |
| #include "__arm_2d_meta_fill_with_des_mask_and_mirror.inc" | ||
|
|
||
| /*----------------------------------------------------------------------------* | ||
| * fill with y-miorro * |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'
| * fill with y-miorro * | |
| * fill with y-mirror * |
| #include "__arm_2d_meta_fill_with_des_mask_and_mirror.inc" | ||
|
|
||
| /*----------------------------------------------------------------------------* | ||
| * fill with xy-miorro * |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'
|
|
||
|
|
||
| /*----------------------------------------------------------------------------* | ||
| * fill with x-miorro * |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'
|
|
||
|
|
||
| /*----------------------------------------------------------------------------* | ||
| * fill with y-miorro * |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'miorro' to 'mirror' / 将 'miorro' 拼写更正为 'mirror'
| # define __ARM_2D_HAS_ASYNC__ 0 | ||
| #endif | ||
|
|
||
| // <q>Enable anti-alias support for all tranform operations. |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'tranform' to 'transform' / 将 'tranform' 拼写更正为 'transform'
| // <q>Enable anti-alias support for all tranform operations. | |
| // <q>Enable anti-alias support for all transform operations. |
| //#define __ARM_2D_CFG_UNSAFE_IGNORE_ALPHA_255_COMPENSATION__ | ||
| // </c> | ||
|
|
||
| // <c1> Ignore calibrartion for small angles in transform operations |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'calibrartion' to 'calibration' / 将 'calibrartion' 拼写更正为 'calibration'
| // <c1> Ignore calibrartion for small angles in transform operations | |
| // <c1> Ignore calibration for small angles in transform operations |
| #undef ARM_2D_PARAM | ||
|
|
||
| /*! | ||
| * \brief a macro helper to be used with ARM_2D_INVODE to improve the |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'INVODE' to 'INVOKE' / 将 'INVODE' 拼写更正为 'INVOKE'
| * \brief a macro helper to be used with ARM_2D_INVODE to improve the | |
| * \brief a macro helper to be used with ARM_2D_INVOKE to improve the |
|
|
||
| #ifndef ARM_2D_INVOKE | ||
| /*! | ||
| * \brief A macro to safely invode a function pointer |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'invode' to 'invoke' / 将 'invode' 拼写更正为 'invoke'
| * \brief A macro to safely invode a function pointer | |
| * \brief A macro to safely invoke a function pointer |
| #define __ARM_ALIGN(__N) __attribute__((aligned(__N))) | ||
|
|
||
| /*! | ||
| * \brief an attribute to specify aligment requirement |
Copilot
AI
Dec 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'aligment' to 'alignment' / 将 'aligment' 拼写更正为 'alignment'
| * \brief an attribute to specify aligment requirement | |
| * \brief an attribute to specify alignment requirement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arm2d的删掉吧
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
添加 ra8p1-titan-board BSP 到主线
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up